Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ipfs daemon start/stop code from replay to util #65

Open
machawk1 opened this issue Dec 9, 2016 · 3 comments
Open

Move ipfs daemon start/stop code from replay to util #65

machawk1 opened this issue Dec 9, 2016 · 3 comments

Comments

@machawk1
Copy link
Member

machawk1 commented Dec 9, 2016

No description provided.

@machawk1
Copy link
Member Author

machawk1 commented Dec 9, 2016

Also, handle ipfs init from the start code if it has not be done already.

@machawk1
Copy link
Member Author

One of the barriers to moving this function is that it is dependent on the IPFS HTTP Client, which is global. This likely hints at a larger underlying problem. Does the client need to be global to have the pseudo-singleton accessible from all functions?

The same global object is also used for .cat()ing multihashes from IPFS.

@machawk1
Copy link
Member Author

machawk1 commented Jul 7, 2020

The global was removed in #640 in favor of a function call to util to obtain the client. The same goes with the .cat()s in replay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant