Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python-native methods to check if ipfs is installed instead of subprocess #87

Open
machawk1 opened this issue Jan 25, 2017 · 0 comments

Comments

@machawk1
Copy link
Member

Per #84, we use ipfs --version via Python subprocess to check if ipfs is installed before firing off subsequent ipwb procedures. @ibnesayeed mentioned that Py2's find_executable and Py3's shutil.which would incur much less expense to the system and it would be better to keep the call in Python instead of forking processes.

@machawk1 machawk1 changed the title Use other methods to check if ipfs is installed Use Python-native methods to check if ipfs is installed instead of subprocess Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant