Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pybin should prefix added path line with a newline #3

Open
cefn opened this issue Apr 14, 2019 · 0 comments · May be fixed by #4
Open

Pybin should prefix added path line with a newline #3

cefn opened this issue Apr 14, 2019 · 0 comments · May be fixed by #4

Comments

@cefn
Copy link

cefn commented Apr 14, 2019

I found that in a default skeleton user directory in Elementary 5 (based on Ubuntu bionic), there is no final newline in the .bashrc file, which instead finishes with the word 'esac' which is the end of a case statement.

Pybin's default editing behaviour therefore causes this error...

bash: /home/cefn/.bashrc: line 171: syntax error near unexpected token `PATH="/home/cefn/.local/bin:$PATH"'
bash: /home/cefn/.bashrc: line 171: `esacexport PATH="/home/cefn/.local/bin:$PATH"'

This is easily resolved by putting a newline after the word 'esac' but it would be better if pybin preceded the edit performed by its 'put' behaviour with a newline to be sure this doesn't happen.

cefn added a commit to cefn/pybin that referenced this issue Apr 14, 2019
@cefn cefn linked a pull request Apr 14, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant