-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight the foreign key connections when selected #309
Comments
This is a good idea. I am, unfortunately, completely out of time these days (only available for urgent bugfixing). So I would gladly accept a PR here. |
@mingodad - as an original author of foreign key relations highlighting (and as someone not really familiar with JS) I can tell you this is a matter of just few lines. See #291 how easy it was to add highlighting of relations (lines). Just add de/highlighting of rows at the end of relations in |
I already gave a look at it but could not find the point to touch, where is the relations stored ? |
Hello Rad0van I just tested your changes and it does exactly what I was expecting it to do, thank you ! |
What do you mean? My changes are merged for more than 2 years already. I thought you wanted highlighting the target row above highlighting the relations (that's what I did). Just pull the current sources from github and you should be ready to go... |
I'm a bit confused it seems that your changes are already there but it was not doing this with the master branch. |
I think that I just did that before opening this issue (I mean cloned this repo and tested it there, I'll do it again). |
I just tested at https://ondras.zarovi.cz/sql/demo/?keyword=default with the schema bellow and it doesn't highlight at all.
|
Somehow the changes from Rad0van got lost/overwritten. |
How about you had a look at the sources of that site? It obviously serves older version (@ondras probably doesn't update it there). Just checkout the version from github and use that... |
It's true I just tested the cloned repo and indeed it does highlight as I was expecting, probably I did the test only on https://ondras.zarovi.cz/sql/demo/ before opening this issue. Could https://ondras.zarovi.cz/sql/demo/ be updated so other people will no do the same as I did and open an issue that doesn't exist ? |
You can create PR to highlight also the labels of target rows ;-) |
Even @ondras forgot about it:
|
This is also a good idea: "You can create PR to highlight also the labels of target rows ;-)" |
Sorry, my bad. I just updated the website to latest |
And I just tested it with the previous xml/schema and now instead of highlight it turn the links invisible. |
Right, they have |
I mean running locally from the repository it does work but online with the update https://ondras.zarovi.cz/sql/demo/ it turns the links invisible. |
...probably an incorrect config file. |
...and it should be working now. |
I just tested again and indeed it's working as expected now, thank you ! |
But I needed to open the developer tools and turn off the cache to load the new version otherwise it was using the cached/incorrect one. |
Would be nice if we could highlight the foreign key connections when one of then is selected, something like on the image bellow, to facilitate view then on dense schemas.
The text was updated successfully, but these errors were encountered: