Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Diffs Fails on SAP Hana Databases #19192

Open
prakharb10 opened this issue Dec 30, 2024 · 0 comments
Open

Table Diffs Fails on SAP Hana Databases #19192

prakharb10 opened this issue Dec 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working data quality

Comments

@prakharb10
Copy link

Affected module
Ingestion Framework

Describe the bug
The supported dialects for Table Diffs includes SAP Hana as listed here:

SUPPORTED_DIALECTS = [
Dialects.Snowflake,
Dialects.BigQuery,
Dialects.Athena,
Dialects.Redshift,
Dialects.Postgres,
Dialects.MySQL,
Dialects.MSSQL,
Dialects.Oracle,
Dialects.Trino,
SapHanaScheme.hana.value,
]

and in the docs. However, I get an error with the message:

ERROR - Unexpected error while running the table diff test: Scheme 'hana' currently not supported

which comes from data-diff. It is clear that data-diff does not support Hana:

https://github.com/datafold/data-diff/blob/1410c6cd0b915ae24a15e03a7de15ff41beebaf0/data_diff/databases/_connect.py#L79-L93

To Reproduce

Setup a Compare 2 Tables for Differences test between a SAP Hana table and a BigQuery table.

Expected behavior

The table difference should run and output the data.

Version:

  • OS: Ubuntu 22.04
  • Python version: 3.11
  • OpenMetadata version: 1.6.1
  • OpenMetadata Ingestion package version: docker.getcollate.io/openmetadata/ingestion:1.6.1

Additional context

None

@TeddyCr TeddyCr added bug Something isn't working data quality labels Jan 6, 2025
@TeddyCr TeddyCr self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data quality
Projects
None yet
Development

No branches or pull requests

2 participants