-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-19197: Deleting Data Product should delete the data asset relationships #19208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
safe to test
Add this label to run secure Github workflows on PRs
labels
Jan 2, 2025
sonika-shah
reviewed
Jan 3, 2025
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java
Show resolved
Hide resolved
sonika-shah
previously approved these changes
Jan 6, 2025
Quality Gate passed for 'open-metadata-ui'Issues Measures |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
ShaileshParmar11
approved these changes
Jan 8, 2025
sonika-shah
approved these changes
Jan 8, 2025
Failed to cherry-pick changes to the 1.6.2 branch. |
karanh37
pushed a commit
that referenced
this pull request
Jan 8, 2025
…ionships (#19208) * Issue-19197: Deleting Data Product should delete the data asset relationships * Issue-19197: Deleting Data Product should delete the data asset relationships * Minor: Fix the deleteByName * add tests for data product delete case * fix flaky tests * update data products fqn keyword mapping * Update table_index_mapping.json * fix flaky test * fix tests * fix flaky tests * fix flakiness --------- Co-authored-by: karanh37 <[email protected]> Co-authored-by: Karan Hotchandani <[email protected]> (cherry picked from commit 490ebde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
safe to test
Add this label to run secure Github workflows on PRs
To release
Will cherry-pick this PR into the release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #19197
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>