Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-19197: Deleting Data Product should delete the data asset relationships #19208

Merged
merged 13 commits into from
Jan 8, 2025

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Jan 2, 2025

Describe your changes:

Fixes #19197

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

sonika-shah
sonika-shah previously approved these changes Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.53% (40607/62929) 40.77% (16269/39905) 43.86% (4915/11207)

Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link

sonarqubecloud bot commented Jan 8, 2025

@sonika-shah sonika-shah self-requested a review January 8, 2025 08:45
@karanh37 karanh37 enabled auto-merge (squash) January 8, 2025 09:12
@karanh37 karanh37 merged commit 490ebde into main Jan 8, 2025
24 of 28 checks passed
@karanh37 karanh37 deleted the issue-19197 branch January 8, 2025 09:38
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Failed to cherry-pick changes to the 1.6.2 branch.
Please cherry-pick the changes manually.
You can find more details here.

karanh37 pushed a commit that referenced this pull request Jan 8, 2025
…ionships (#19208)

* Issue-19197: Deleting Data Product should delete the data asset relationships

* Issue-19197: Deleting Data Product should delete the data asset relationships

* Minor: Fix the deleteByName

* add tests for data product delete case

* fix flaky tests

* update data products fqn keyword mapping

* Update table_index_mapping.json

* fix flaky test

* fix tests

* fix flaky tests

* fix flakiness

---------

Co-authored-by: karanh37 <[email protected]>
Co-authored-by: Karan Hotchandani <[email protected]>
(cherry picked from commit 490ebde)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting Data Product should delete the data asset relationships
4 participants