Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bytes limit feature to batch processor #8272

Open
yutingcaicyt opened this issue Aug 23, 2023 · 4 comments
Open

add bytes limit feature to batch processor #8272

yutingcaicyt opened this issue Aug 23, 2023 · 4 comments

Comments

@yutingcaicyt
Copy link

Is your feature request related to a problem? Please describe.
When I use Otel, I find it very difficult to limit the bytes size of a request to the destination. The 'sendBatchMaxSize' in batch processor only limits the number of logs, not the bytes size. If the size of a request cannot be accurately limited, it will cause some trouble to the receiving end.

Describe the solution you'd like
Maybe we can add a feature that limits the bytes size of a batch into the batch processor.

@seankhliao
Copy link
Contributor

The byte size depends a lot on the final exporter protocol / encoding.
It doesn't seem like the batch processor will have sufficient information to calculate this accurately?

@yutingcaicyt
Copy link
Author

It does make sense. So is the best way to handle this in the final exporter? However, This doesn't feel very generic.

@dmitryax
Copy link
Member

This is something we can have once #8122 is implemented

@nicolastakashi
Copy link

This is something we can have once #8122 is implemented

@dmitryax is this still a requirement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants