Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES #5462

Open
vishweshbankwar opened this issue Mar 20, 2024 · 4 comments
Open
Labels
enhancement New feature or request needs-spec-change Issues which require the OpenTelemetry Specification to clarify or define behavior
Milestone

Comments

@vishweshbankwar
Copy link
Member

No description provided.

@cjablonski76
Copy link

@vishweshbankwar any movement on this topic? The company I work for would benefit from this, as would many others I presume.

It's difficult to convince a company to start depending on the attributes logged with OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES enabled if we know that it is planned to go away without a moments notice.

@vishweshbankwar vishweshbankwar added this to the 1.10.0 milestone Aug 1, 2024
@vishweshbankwar
Copy link
Member Author

@cjablonski76 - its planned for 1.10.0 milestone(Nov).

@CodeBlanch
Copy link
Member

I just opened a new spec PR to try and get the ball moving: open-telemetry/semantic-conventions#1339

I had another one open but it just went into a void 😢

@cijothomas cijothomas added the needs-spec-change Issues which require the OpenTelemetry Specification to clarify or define behavior label Sep 16, 2024
@cijothomas
Copy link
Member

Removing from 1.10.0 milestone, as it is not possible to get blessing from Spec/Conventions in this time. There will be changes to OTel Events based on open-telemetry/oteps#265, and it is an open question whether ILogger Logs with EventName should be an Event or not, and more importantly - it is an open question if LogRecord adds a top-level field for EventName vs putting it as attributes. Until these questions are resolved, we cannot make this stabilized.

(The alternate of stabilizing a .NET specific way by storing this in attribute like "dotnet.ilogger.event.name" is highly undesired, given OTel's desire to make Events a first class thing.)

Unfortunately, there is no firm ETA for this item now, as we rely on spec progress which (as of today), has no firm ETA either.

@cijothomas cijothomas removed this from the 1.10.0 milestone Sep 16, 2024
@CodeBlanch CodeBlanch added this to the Future milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-spec-change Issues which require the OpenTelemetry Specification to clarify or define behavior
Projects
None yet
Development

No branches or pull requests

4 participants