Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the autosdk and otelglobal instrumentation #1397

Closed
MrAlias opened this issue Dec 10, 2024 · 1 comment
Closed

Merge the autosdk and otelglobal instrumentation #1397

MrAlias opened this issue Dec 10, 2024 · 1 comment
Assignees

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Dec 10, 2024

We currently have two ways to instrument the opentelemetry-go global API. These should be unified into a single probe. If the global API being used is a version prior to the auto/sdk package integration the original otelglobal instrumentation should be used. Otherwise, the autosdk instrumentation should be used.

@MrAlias MrAlias converted this from a draft issue Dec 10, 2024
@MrAlias MrAlias self-assigned this Dec 10, 2024
@MrAlias MrAlias moved this from Todo to In Progress in Go Auto Instrumentation: Beta Dec 10, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 10, 2024

This "merge" isn't needed. Based on #1405 all we will need to do is keep the autosdk probe as is and instrument the newSpan function to "turn on" the use of auto/sdk in the global API. The current global instrumentation will continue to work if the code-path is not changed based on this flag setting.

We will need to work out how to instrument (*tracer).newSpan only for versions > 1.32 of otel. That can be included in #1399 as an action item.

@MrAlias MrAlias closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Auto Instrumentation: Beta Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant