Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[operator] manager.serviceMonitor.enabled is redundant #1437

Open
pl4nty opened this issue Nov 30, 2024 · 2 comments
Open

[operator] manager.serviceMonitor.enabled is redundant #1437

pl4nty opened this issue Nov 30, 2024 · 2 comments
Labels
chart:operator Issue related to opentelemetry-operator helm chart

Comments

@pl4nty
Copy link

pl4nty commented Nov 30, 2024

The operator now creates a ServiceMonitor by default, taking over the chart's ServiceMonitor if it exists. So manager.serviceMonitor.enabled is redundant, a ServiceMonitor will always be created.

I don't want a ServiceMonitor, so I used this workaround:

manager:
  extraArgs:
    - --enable-cr-metrics=false

Also tracked on the operator repo as open-telemetry/opentelemetry-operator#3474

@TylerHelmuth TylerHelmuth added the chart:operator Issue related to opentelemetry-operator helm chart label Dec 2, 2024
@TylerHelmuth
Copy link
Member

@jaronoff97 how do you want to handle this in the chart?

@jaronoff97
Copy link
Contributor

i was away when this was added... but i was under the impression this was only the case in openshift environments. Looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:operator Issue related to opentelemetry-operator helm chart
Projects
None yet
Development

No branches or pull requests

3 participants