Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement instrument advisory (hint) for Metric API #1241

Closed
cijothomas opened this issue Aug 31, 2023 · 5 comments
Closed

Implement instrument advisory (hint) for Metric API #1241

cijothomas opened this issue Aug 31, 2023 · 5 comments
Assignees
Labels
A-metrics Area: issues related to metrics M-api M-sdk

Comments

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-advisory-parameters New spec. The advisory needs to be exposed on Metric API, and then the SDK must leverage them for aggregation.

@cijothomas cijothomas added the A-metrics Area: issues related to metrics label Aug 31, 2023
@hdost hdost added release:allowed-for-stable Changes that can still be added before Stable, but won't require Breaking Interfaces. M-api M-sdk labels Feb 21, 2024
@hdost hdost added this to the Metrics API Stable milestone Feb 21, 2024
@hdost hdost added the triage:todo Needs to be traiged. label Feb 21, 2024
@cijothomas cijothomas self-assigned this Feb 22, 2024
@cijothomas
Copy link
Member Author

@cijothomas cijothomas removed release:allowed-for-stable Changes that can still be added before Stable, but won't require Breaking Interfaces. triage:todo Needs to be traiged. labels May 1, 2024
@alfiejfs
Copy link

Hi, is this still planned for the beta release on August 2nd? I see it mentioned in #1719 but I don't see it in the milestone. And is this just a temporary API patch whilst views are removed, or is it intended to stay? Cheers :)

@cijothomas
Copy link
Member Author

Hi, is this still planned for the beta release on August 2nd? I see it mentioned in #1719 but I don't see it in the milestone. And is this just a temporary API patch whilst views are removed, or is it intended to stay? Cheers :)

Yes. (Note we got delay by few weeks).
Will fix milestone, thanks for catching it. It'll be a permanent feature, as it is part of OTel's Stable specification.

@cijothomas
Copy link
Member Author

This didn't land for the current release, will be covered in the next release, ~3 weeks from now. @utpilla is working on this.

@cijothomas
Copy link
Member Author

Closing as this is covered by 0.26 release for histogram hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-metrics Area: issues related to metrics M-api M-sdk
Projects
None yet
Development

No branches or pull requests

4 participants