-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to have some namespaces to NOT be processed by default #363
Comments
If I understand your request correctly, this is already supported. You can refer to the following example: https://github.com/jsuereth/semantic-conventions-java/blob/475a041a92dfc8cb5ea618456d8d4e992b1c273d/buildscripts/templates/registry/java/weaver.yaml The Let me know if you had something different in mind. Thanks! |
I propose to add |
To mark namespaces to be excluded by default, we could either add a default Currently, the configuration overriding process does not support removing items from a list, but this feature could be added. For instance, let’s say you have the following declaration in the parent directory of your templates: # weaver.yaml in parent directory or ~/.weaver/
params:
excluded_namespace:
- ios
- signalr
- aspnetcore
- ... What you're asking for could be implemented with a "negative" override (a feature not yet supported) as follows: # weaver.yaml in template directory
params:
excluded_namespace$remove:
- signalr This would remove the Alternatively, another approach could be to use a different parameter and implement more complex logic in the JQ filters. |
Maybe it would be good to have some namespaces that by default are not processed (like signalr, aspnetcore, etc).
They would need to be added explicitly in the config.
CC @jsuereth
The text was updated successfully, but these errors were encountered: