You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like all implementations of AbstractDBBuilder#initializeProcess() in the following subclasses:
CommunityDBBuilder
DatasetDBBuilder
ServiceDBBuilder
PatentDBBuilder
ProjectDBBuilder
ResearchInitiativeDBBuilder
SoftwareHeritageOriginDBBuilder
are quite similar and it should be possible to refactor it and put most of the code in a shared method.
We should also check if targetDbFile.setWritable(true); is really needed and justified since it doesn't work for non-existing files. We should check if it is possible this file could be already created e.g. by previous execution of this process on the same datanode. This was referenced in #1398 (comment) as a part of CR process.
The text was updated successfully, but these errors were encountered:
marekhorst
changed the title
Refactor AbstractDBBuilder hierarchy and check if targetDbFile needs to be explicitly set as writeable
Refactor AbstractDBBuilder hierarchy and check if targetDbFile needs to be explicitly set as writable
May 12, 2023
It looks like all implementations of
AbstractDBBuilder#initializeProcess()
in the following subclasses:CommunityDBBuilder
DatasetDBBuilder
ServiceDBBuilder
PatentDBBuilder
ProjectDBBuilder
ResearchInitiativeDBBuilder
SoftwareHeritageOriginDBBuilder
are quite similar and it should be possible to refactor it and put most of the code in a shared method.
We should also check if
targetDbFile.setWritable(true);
is really needed and justified since it doesn't work for non-existing files. We should check if it is possible this file could be already created e.g. by previous execution of this process on the same datanode. This was referenced in #1398 (comment) as a part of CR process.The text was updated successfully, but these errors were encountered: