ci: improve release workflow #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasaplus1
commented
Jul 31, 2023
| @@ -22,6 +22,7 @@ jobs: | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 16 | |||
| registry-url: 'https://registry.npmjs.org' | |||
There was a problem hiding this comment.
.npmrc のセットアップをsetup-nodeにしてもらいます。
sasaplus1
commented
Jul 31, 2023
| @@ -30,17 +31,14 @@ jobs: | |||
| node_modules | |||
| */*/node_modules | |||
| key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}-v2 | |||
| - run: npm install -g npm@9 | |||
There was a problem hiding this comment.
--provenance で公開したいので npm9 にします。
sasaplus1
commented
Jul 31, 2023
Comment on lines
+40
to
+41
| git config --global user.name 'github-actions[bot]' | ||
| git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com' |
There was a problem hiding this comment.
コミットしたユーザーがGitHub Actionsのように表示されます。
openameba/ameba-color-palette.css#93 (comment)
sasaplus1
commented
Jul 31, 2023
| @@ -51,6 +49,8 @@ jobs: | |||
| run: yarn lerna publish ${{ steps.extract_branch.outputs.version }} --conventional-commits --create-release github --yes --no-private | |||
| env: | |||
| GH_TOKEN: ${{ github.token }} | |||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
| NPM_CONFIG_PROVENANCE: true | |||
There was a problem hiding this comment.
npm から直接公開するのではないため --provenance の代わりに環境変数で対応します。
sasaplus1
commented
Jul 31, 2023
| @@ -51,6 +49,8 @@ jobs: | |||
| run: yarn lerna publish ${{ steps.extract_branch.outputs.version }} --conventional-commits --create-release github --yes --no-private | |||
| env: | |||
| GH_TOKEN: ${{ github.token }} | |||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
There was a problem hiding this comment.
.npmrc の設定を setup-node にしているため NODE_AUTH_TOKEN に NPM_TOKEN を指定しています。
sasaplus1
commented
Jul 31, 2023
| @@ -51,6 +49,8 @@ jobs: | |||
| run: yarn lerna publish ${{ steps.extract_branch.outputs.version }} --conventional-commits --create-release github --yes --no-private | |||
| env: | |||
| GH_TOKEN: ${{ github.token }} | |||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
| NPM_CONFIG_PROVENANCE: true | |||
| - name: Create Pull Request | |||
| run: > | |||
| curl | |||
There was a problem hiding this comment.
gh コマンドに変えようかと思いましたが、たしかAPI経由で実行しないとワークフローが実行されない関係でこの記述をしていた記憶があったのでとりあえず変更しませんでした。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release workflow を改良しました。