Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Dataset for DE9IM functions in DGGS #37

Open
rggibb opened this issue Oct 27, 2021 · 1 comment
Open

Validation Dataset for DE9IM functions in DGGS #37

rggibb opened this issue Oct 27, 2021 · 1 comment

Comments

@rggibb
Copy link
Collaborator

rggibb commented Oct 27, 2021

Logically, one could just take any existing DE9IM validation dataset and import it into a DGGS and perform the equivalent tests. However DGGS provides the capability to specify the precison with which to do a test, and the results can be both precision and DGGS dependent. For example:

For the pair of shapes:

image

Logically we would expect square.overlaps(triangle) to return True

But if we import theses shapes into a DGGS at three different levels, we might get the following:

image

Further the nuances of the result are both DGGS architecture dependent (hexagons vs squares etc) and DGGS RS dependent even within the same architecture.

So how do we address this in order to get a robust test suite with consistent validation results for all DGGS RSs.

@jerstlouis
Copy link
Member

@rggibb This is a very interesting topic.

Even without implementing a DGGS API, the issue of precision came up in our implementation of DE9IM and CQL2 for OGC API - Features, since we import the data in a DGGS data store. The CQL2 ATS includes a series of useful spatial comparison tests.

So I would say that DE9IM functions are automatically dependent on refinement levels in this case.

Perhaps some guidance in this regard is needed for the Abstract Test Suite specifically for the CQL2 Filtering of both Zone Data and Zone Queries, which can include DE9IM spatial operators.

Our deployment of the CQL2 test dataset is available here, and we support DGGS zone data and zone queries using CQL2 for the three DGGRS in Annex B. Some extensive testing / comparisons with other implementations would be useful to make progress on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants