From 762392b0d780a03b54b73bcb19b1eb2c46c85ef3 Mon Sep 17 00:00:00 2001 From: Allen <64019758+aboddie@users.noreply.github.com> Date: Thu, 5 Dec 2024 11:27:42 -0500 Subject: [PATCH 1/4] Update INEGI Url --- R/SDMXServiceProvider-methods.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/SDMXServiceProvider-methods.R b/R/SDMXServiceProvider-methods.R index 1a535c7..9c12a3d 100644 --- a/R/SDMXServiceProvider-methods.R +++ b/R/SDMXServiceProvider-methods.R @@ -294,8 +294,8 @@ setSDMXServiceProviders <- function(){ # nocov start agencyId = "INEGI", name = "Instituto Nacional de Estad\u00edstica y Geograf\u00eda (M\u00e9jico)", scale = "national", country = "MEX", builder = SDMXREST21RequestBuilder( - regUrl = "http://sdmx.snieg.mx/service/Rest", - repoUrl = "http://sdmx.snieg.mx/service/Rest", + regUrl = "https://sdmx.snieg.mx/ServiceV6/rest", + repoUrl = "https://sdmx.snieg.mx/ServiceV6/rest", compliant = FALSE ) ) From ad9acfb14ef6b09986a013b38194b90f4f5529cd Mon Sep 17 00:00:00 2001 From: Allen <64019758+aboddie@users.noreply.github.com> Date: Thu, 5 Dec 2024 12:27:31 -0500 Subject: [PATCH 2/4] Update ILO and WBG_WITS --- R/SDMXServiceProvider-methods.R | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/R/SDMXServiceProvider-methods.R b/R/SDMXServiceProvider-methods.R index 9c12a3d..c3bd4ea 100644 --- a/R/SDMXServiceProvider-methods.R +++ b/R/SDMXServiceProvider-methods.R @@ -222,8 +222,8 @@ setSDMXServiceProviders <- function(){ # nocov start ILO <- SDMXServiceProvider( agencyId = "ILO", name = "International Labour Organization of the United Nations", builder = SDMXREST21RequestBuilder( - regUrl = "https://www.ilo.org/sdmx/rest", - repoUrl = "https://www.ilo.org/sdmx/rest", + regUrl = "https://sdmx.ilo.org/rest", + repoUrl = "https://sdmx.ilo.org/rest", compliant = TRUE, skipProviderId = TRUE) ) @@ -231,8 +231,8 @@ setSDMXServiceProviders <- function(){ # nocov start WBG_WITS <- SDMXServiceProvider( agencyId = "WBG_WITS", name = "World Integrated Trade Solution", builder = SDMXREST21RequestBuilder( - regUrl = "http://wits.worldbank.org/API/V1/SDMX/V21/rest", - repoUrl = "http://wits.worldbank.org/API/V1/SDMX/V21/rest", + regUrl = "https://wits.worldbank.org/API/V1/SDMX/V21/rest", + repoUrl = "https://wits.worldbank.org/API/V1/SDMX/V21/rest", compliant = TRUE, skipProviderId = TRUE ) ) From 42611592708ba6deb524b15b8706aecfb2606d92 Mon Sep 17 00:00:00 2001 From: Allen <64019758+aboddie@users.noreply.github.com> Date: Thu, 5 Dec 2024 13:36:31 -0500 Subject: [PATCH 3/4] Update test pointing at deleted artifacts --- tests/testthat/test_Main_Helpers.R | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testthat/test_Main_Helpers.R b/tests/testthat/test_Main_Helpers.R index 4b08f9a..1d5d95f 100644 --- a/tests/testthat/test_Main_Helpers.R +++ b/tests/testthat/test_Main_Helpers.R @@ -180,7 +180,7 @@ test_that("OECD - dataflow",{ #-> datastructure test_that("OECD - datastructure",{ testthat::skip_on_cran() - sdmx <- readSDMX(providerId = "OECD", resource = "datastructure", resourceId = "TABLE1") + sdmx <- readSDMX(providerId = "OECD", resource = "datastructure", resourceId = "DSD_PRICES") if(!is.null(sdmx)){ expect_is(sdmx, "SDMXDataStructureDefinition") } @@ -189,8 +189,8 @@ test_that("OECD - datastructure",{ #-> data test_that("OECD - data",{ testthat::skip_on_cran() - sdmx <- readSDMX(providerId = "OECD", resource = "data", - flowRef = "MIG", key = list("TOT", NULL, NULL), start = 2011, end = 2011) + sdmx <- readSDMX(providerId = "OECD", resource = "data", flowRef = "DSD_PRICES@DF_PRICES_N_CP01", + key = key = list("GRC", NULL, NULL, NULL, NULL, NULL, NULL, NULL), start = 2020, end = 2020) if(!is.null(sdmx)){ expect_is(sdmx, "SDMXMessageGroup") } @@ -582,7 +582,7 @@ test_that("ISTAT - datastructure",{ test_that("ISTAT - data",{ testthat::skip_on_cran() sdmx <- readSDMX(providerId = "ISTAT", resource = "data", - flowRef = "12_60", start = 2015, end = 2015) + flowRef = "12_60_DF_DCCV_CONSACQUA_1", start = 2015, end = 2015) if(!is.null(sdmx)){ expect_is(sdmx, "SDMXGenericData") } From e02f895b44a52c4c00f55fc45a6ee9f4e2580076 Mon Sep 17 00:00:00 2001 From: Allen <64019758+aboddie@users.noreply.github.com> Date: Thu, 5 Dec 2024 13:56:42 -0500 Subject: [PATCH 4/4] typo --- tests/testthat/test_Main_Helpers.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test_Main_Helpers.R b/tests/testthat/test_Main_Helpers.R index 1d5d95f..63d585f 100644 --- a/tests/testthat/test_Main_Helpers.R +++ b/tests/testthat/test_Main_Helpers.R @@ -190,7 +190,7 @@ test_that("OECD - datastructure",{ test_that("OECD - data",{ testthat::skip_on_cran() sdmx <- readSDMX(providerId = "OECD", resource = "data", flowRef = "DSD_PRICES@DF_PRICES_N_CP01", - key = key = list("GRC", NULL, NULL, NULL, NULL, NULL, NULL, NULL), start = 2020, end = 2020) + key = list("GRC", NULL, NULL, NULL, NULL, NULL, NULL, NULL), start = 2020, end = 2020) if(!is.null(sdmx)){ expect_is(sdmx, "SDMXMessageGroup") }