Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check in github actions for see if jenkinsfile in PR has a test associated with it #1444

Open
1 task
abhinavGupta16 opened this issue Jan 10, 2022 · 4 comments
Labels
enhancement New Enhancement

Comments

@abhinavGupta16
Copy link
Contributor

abhinavGupta16 commented Jan 10, 2022

Is your feature request related to a problem? Please describe

We need to have regression tests for all jenkins job that we create. As the number of contributors for the jobs increase and the number of jobs increase, we need a check that would make sure every jenkinsfile that is added has a regression test for it, else, the ci would prevent the PR from merging.

Describe the solution you'd like

One possible solution could be to check if every jenkinsfile in the PS has a jenkinsfile.txt as well.

Open to other solutions

Acceptance Criteria

  • given I create a jenkins file without a test, ci should fail preventing me from merging the PR

Describe alternatives you've considered

No response

Additional context

No response

@abhinavGupta16 abhinavGupta16 added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jan 10, 2022
@dblock
Copy link
Member

dblock commented Jan 11, 2022

Good idea. Note that sometimes it's not possible, notably because issues such as jenkinsci/JenkinsPipelineUnit#434, but we should be able to at least have placeholders that reference these.

@dblock
Copy link
Member

dblock commented Jan 11, 2022

Could also think of this as code coverage and report Jenkinsfile's as code and see whether those are tested or not.

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Jan 11, 2022
@gaiksaya
Copy link
Member

[Triage] @abhinavGupta16 Can you please create issues for existing jenkinsfile?
Thanks!

@rblcoder
Copy link
Contributor

rblcoder commented Nov 4, 2023

@gaiksaya Can this be a separate python file run in a separate GHA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants