Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Add tunnel" quick fix not shown after already fixing one #10614

Open
Nekzuris opened this issue Dec 19, 2024 · 6 comments · May be fixed by #10632
Open

"Add tunnel" quick fix not shown after already fixing one #10614

Nekzuris opened this issue Dec 19, 2024 · 6 comments · May be fixed by #10632

Comments

@Nekzuris
Copy link
Contributor

Nekzuris commented Dec 19, 2024 •
edited
Loading

URL

No response

How to reproduce the issue?

Create a waterway that crosses two roads.

When selecting the waterway, the validator correctly shows the quick fix menu the first time but after selecting "Add tunnel", the next issue only show an option to ignore the problem.

Screenshot(s) or anything else?

3
1
2

I understand that this happens because after the tunnel is created, the selection includes three waterways and the validator don't know what to do.
It should either:

  • show the full quick fix menu
  • automatically change selection to the next problematic segment
  • don't show "ignore this issue" because it might mislead mappers into thinking there’s nothing else to do to fix it

And clicking the yellow box zooms in on the problematic way but still keeps the selection the same, so the quick fix menu is still incomplete.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Chrome, Firefox
@Darshit42
Copy link

hi , i tried replicating the issue but it didnt occur can you upload a video of it?

@Nekzuris
Copy link
Contributor Author

tunnel.creation.issue.mp4

@Deeptanshu-sankhwar
Copy link
Contributor

Thanks for sharing this issue, @Nekzuris. I have been able to replicate this issue, the third option to not show "ignore this issue" may be the most straightforward approach. About the implementation for option 1 & 2, if we show the full quick fix menu, and if the user selected to add a tunnel further, we can't know which feature is the tunnel getting added to right?

For option 2, what does change selection to the next problematic segment mean?

Thanks a lot

@Nekzuris
Copy link
Contributor Author

For option 2, what does change selection to the next problematic segment mean?

Exactly what I did manually at 0:05, but I don't think this is a good solution to implement.

we can't know which feature is the tunnel getting added to right?

We can know for sure because if you click the top of the yellow box it zoom the map exactly were the tunnel should be added.

@Darshit42
Copy link

i guess we can change it to highlight the next issue and show full quick fix menu , i would like to work on this issue (just a thought but we can give a small popup or something which tells user that everything's fine after fix)

@Deeptanshu-sankhwar Deeptanshu-sankhwar linked a pull request Dec 28, 2024 that will close this issue
Open
@Deeptanshu-sankhwar
Copy link
Contributor

hi @Nekzuris @Darshit42 I have raised a PR that doesn't show ignore_issue message that might mislead the mappers. Please do check it out.

Thanks

Screen.Recording.2024-12-28.at.3.59.51.PM.1.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Deeptanshu-sankhwar @Nekzuris @Darshit42