So I just stumbled upon this PR while looking again at #16 and after testing it I don't see how it "fixes" anything.

The meta nfproto ipv4 match is still emitted by fw4 for every rule that refers to the set. Sure you can add an option family 'any' to the ipset configuration, it will not emit a warning but it changes nothing.

So I just stumbled upon this PR while looking again at #16* and after testing it I don't see how it "fixes" anything.

The meta nfproto ipv4 match is still emitted by fw4 for every rule that refers to the set. Sure you can add an option family 'any' to the ipset configuration, it will not emit a warning but it changes nothing.

@f00b4r0 To maintain compatibility with the configuration, the default value for the ipset family is still ipv4.

I tested the configuration from #16 as follows:

config rule
  option name 'Forward-auth-captive'
  option src 'lan'
  option dest 'wan'
  option proto 'any'
  option target 'ACCEPT'
  option ipset 'captive'

config ipset
  option name 'captive'
  option family 'any'
  list match 'src_mac'

The generated nftables rules are:

set captive {
  type ether_addr
}
...
chain forward_lan {
  ...
  ether saddr @captive counter packets 0 bytes 0 jump accept_to_wan comment "!fw4: Forward-auth-captive"
  ...
}

It can be seen that this modification is effective.

I know, it duly prints warning when that is employed.

@zsien unfortunately while the test you performed works, this one doesn't:

config redirect
        option name 'Redirect-unauth-captive'
        option src 'lan'
        option src_dport '80'
        option proto 'tcp'    
        option target 'DNAT'   
        option reflection '0'
        option ipset '!captive'

config ipset
        option name 'captive'
        option family 'any'
        list match 'src_mac'

It fails to load the firewall with:

/dev/stdin:236:35-36: Error: syntax error, unexpected !=, expecting newline or semicolon
		meta nfproto ipv4 tcp dport 80  != @captive counter redirect to 80 comment "!fw4: Redirect-unauth-captive"
		                                ^^

meta nftproto ipv4 is still emitted and ether saddr is missing.
It's likely that other corner cases are thus broken by your change.

I also don't think that src_mac ipsets should still default to ipv4, but that's left to the maintainer's appreciation.

HTH