Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to same bytecode level as io.zipkin.brave:brave #30

Open
codefromthecrypt opened this issue Oct 28, 2019 · 0 comments
Open

Backport to same bytecode level as io.zipkin.brave:brave #30

codefromthecrypt opened this issue Oct 28, 2019 · 0 comments

Comments

@codefromthecrypt
Copy link
Contributor

There's no reason to have this bytecode JDK 1.8, and it can break api later to rely on it and have to move back after people are using this library. Propagation is the most low-level api, so we should be conservative even if we design interfaces to fit functional ones and/or method references.

Let's move back to source 1.6 (with retrolambda so that the IDE still feels like 1.8) and setup animal sniffer to ensure there is no accidental leaks of functions, streams classes etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant