Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude private repositories by default #2

Open
atanisoft opened this issue Jan 16, 2024 · 2 comments
Open

Exclude private repositories by default #2

atanisoft opened this issue Jan 16, 2024 · 2 comments

Comments

@atanisoft
Copy link

Private repositories should not include the links to view the model since the external sites do not have read access to private repositories. Embedding the KiCanvas code might work but it would need to use an authenticated call to retrieve the KiCad files from the private repository.

@sphawes
Copy link
Member

sphawes commented Jan 16, 2024

oh, damn that's a great thought! weird edge case. shouldnt be too hard to check if the repo is private, and effectively disable the extension. the auth might be weird, not sure how we'd go about doing that.

@atanisoft
Copy link
Author

Yeah, it's definitely an edge case. I'm not sure how auth might be possible outside of using something like fetch to retrieve the file into a local variable and pass the content along to the viewer as maybe base64 encoded (or for direct embedding pass the var itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants