New Apps Help and Couple Ideas

[gdeeble]

Hey all!

First thanks for keeping this stuff going. It was definitely heartbreaking hearing about Tteck, back in November, but his and these scripts have been a wonderful resource with setting up some of these apps.

I'm still very new to using Github and development processes outlined so please bear with me on this. Most of my development has been private and honestly willy nilly. I'm trying to make sure I stick to the guidelines for consistency and hopefully have done ok. I've put the install scripts for Openspeedtest in here and was wondering if anyone would be up for critiquing them, maybe giving pointers for anything that could be done better. They are pointing to my repo so I could test the installation process, and have confirmed it works with both Debian 12 and Ubuntu 24.04 without any issues.

While writing out the scripts for Openspeedtest, I notice that if I don't update the source in the CT script and the "community-scripts" reference in the function files, it wouldn't work(as expected since they don't exist here). My thought would be to see if we could set up a global variable that was set before importing the function scripts so that they could point to a private repo(mainly for creation and testing purposes) so that it could be dynamically configured at the time of execution. My thought would be if adding a way to check for a repo argument and set that in the script as the global variable, then call it everywhere else with the understanding that if it's not set then it would utilize community-scripts as the repo.

Please let me know if there is any feedback, as I look at this as an opportunity to give back to the community, not to mention an opportunity to strengthen my skills.

Scripts:
https://raw.githubusercontent.com/gdeeble/ProxmoxVE/refs/heads/main/ct/openspeedtest.sh
https://raw.githubusercontent.com/gdeeble/ProxmoxVE/refs/heads/main/install/openspeedtest-install.sh

Cheers!
-Gary