Fav points styles lost

[pawelpbm]

Description

I have a lot of fav points in multiple folders. I usually apply styles on folder level for my favs to have different colors and icons.

Sometimes when OsmAnd is killed styles of favs are reset to the default one. This happened to me multiple times. From what I noticed styles were lost for most folders but not for all (I think it might be for the folders I recently interacted with?)

Steps to reproduce

Do some changes to fav points. Kill the app. Probably, but not sure. Also, maybe kill the app when Cloud sync is in progress?

Actual result

Styles of fav points are lost be lost.

Expected result

Styles should not be lost.

Your Environment (required)

OsmAnd Version: 4.9.10
Android/iOS version: Android 15
Device model: Pixel 9 
Crash-Logs: ?

[Rowin63]

Something similar happened to me recently (I mentioned it as a side note in another issue and unfortunately do not remember anymore where...)

[DmitryAlexei]

Indeed, changes made to favorites appearance (on folder level) may not be preserved when a user quits OsmAnd right after these changes were made.

Steps to reproduce:

• download and import favorites. For example, iOverlander_Peru.zip. You may also create favorites yourself.
• go to menu > my places > favorites > choose one of the folders > tap tree dots > Change default appearance
• in Edit category menu, change the color of the folder and its icon
• see that changes you made have been applied
• exit and kill OsmAnd app, after that relaunch the app
• go to menu > my places > favorites and see if your changes persist

Actual result:

• changes are not preserved (in my tests, both for favorites created from .gpx or directly on the map)
• if you delete favorite folders and directly after that quit OsmAnd, some deleted folders will be automatically restored
• need to note, that sometimes changes may be saved
• see video

2025-01-03.00.22.11.mp4

My device: Samsung galaxy note 20 ultra, Android 13, OsmAnd~ 5.0.0#4045m, released: 2025-01-02

logcat (4).log

Probably this issue is related with #20957

[pawelpbm]

@DmitryAlexei Thank for confirming and for detailed repro.

I hope that the solution here would be to have some transactional system for saving points (or data in general) and/or checksums on the data. I think that would also help in some way with Cloud sync issues I've seen before...