Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset all filter for Smart Folder - Crash #21827

Open
1 task
dmpr0 opened this issue Jan 30, 2025 · 1 comment
Open
1 task

Reset all filter for Smart Folder - Crash #21827

dmpr0 opened this issue Jan 30, 2025 · 1 comment

Comments

@dmpr0
Copy link
Contributor

dmpr0 commented Jan 30, 2025

Description

How to reproduce

  • MenuMy PlacesTracks
  • Tap on 3 dot's icon to access menu – tap Add smart folder
  • Enter name – tap Save
  • On new Smart folder screen - Tap on 3 dot's icon to access menu – Edit filter
  • Decrease max Length – tap Show
  • Tap Reset All

Actual result

EditFilterCrash.mov
Crash
Version  OsmAnd~ 5.0.0#4255m
30.01.2025 1:49:46
Apk Version : 5.0.0#4255m 5000
Exception occurred in thread Thread[AsyncTask #8,5,main] : 
java.lang.RuntimeException: An error occurred while executing doInBackground()
	at android.os.AsyncTask$4.done(AsyncTask.java:415)
	at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:434)
	at java.util.concurrent.FutureTask.setException(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:322)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
	at java.lang.Thread.run(Thread.java:1119)
Caused by: android.util.AndroidRuntimeException: Animators may only be run on Looper threads
	at android.animation.ValueAnimator.cancel(ValueAnimator.java:1179)
	at android.graphics.drawable.RippleDrawable.exitPatternedBackgroundAnimation(RippleDrawable.java:834)
	at android.graphics.drawable.RippleDrawable.setBackgroundActive(RippleDrawable.java:383)
	at android.graphics.drawable.RippleDrawable.onStateChange(RippleDrawable.java:341)
	at android.graphics.drawable.Drawable.setState(Drawable.java:836)
	at android.view.View.drawableStateChanged(View.java:26047)
	at android.view.ViewGroup.drawableStateChanged(ViewGroup.java:7752)
	at android.view.View.refreshDrawableState(View.java:26129)
	at android.view.ViewGroup.drawableStateChanged(ViewGroup.java:7766)
	at android.view.View.refreshDrawableState(View.java:26129)
	at android.view.View.setEnabled(View.java:13749)
	at net.osmand.plus.helpers.AndroidUiHelper.setEnabled(AndroidUiHelper.java:152)
	at net.osmand.plus.widgets.dialogbutton.DialogButtonViewHolder.updateEnabled(DialogButtonViewHolder.java:131)
	at net.osmand.plus.widgets.dialogbutton.DialogButton.setEnabled(DialogButton.java:57)
	at net.osmand.plus.myplaces.tracks.SearchMyPlacesTracksFragment.updateButtonsState(SearchMyPlacesTracksFragment.java:137)
	at net.osmand.plus.myplaces.tracks.SearchMyPlacesTracksFragment.onFilterChanged(SearchMyPlacesTracksFragment.java:410)
	at net.osmand.plus.myplaces.tracks.TracksSearchFilter.onFilterChanged(TracksSearchFilter.java:290)
	at net.osmand.shared.gpx.filters.DateTrackFilter.setValueFrom(DateTrackFilter.kt:52)
	at net.osmand.plus.myplaces.tracks.TracksSearchFilter$1.doInBackground(TracksSearchFilter.java:80)
	at net.osmand.plus.myplaces.tracks.TracksSearchFilter$1.doInBackground(TracksSearchFilter.java:71)
	at net.osmand.plus.OsmAndTaskManager$InternalTaskExecutor.doInBackground(OsmAndTaskManager.java:35)
	at android.os.AsyncTask$3.call(AsyncTask.java:394)
	at java.util.concurrent.FutureTask.run(FutureTask.java:317)
	... 3 more

Expected result

  • Reseting Smart Folder filters

Environment
OsmAnd Version: 5.0.0#4255m
Android: 15
Device model: Google Pixel 6A

@yuriiurshuliak
Copy link

The bug has been reproduced following your steps:

  1. Open the OsmAnd app.
  2. Navigate to Menu → My Places → Tracks.
  3. Tap the three-dot menu and select Add Smart Folder.
  4. Enter a name for the folder and tap Save.
  5. On the newly created Smart Folder screen, tap the three-dot menu and select Edit Filter.
  6. Decrease the Max Length filter value and tap Show.
  7. Tap Reset All.

Actual Result: The app crashes when attempting to reset all filters.

Crash logs

OsmAnd~ 5.0.0#4305m, released: 2025-02-04

video_2025-02-04_17-14-13.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants