Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird edge case with shared.rst translations #38

Open
JulianGro opened this issue Jun 9, 2023 · 0 comments
Open

Weird edge case with shared.rst translations #38

JulianGro opened this issue Jun 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@JulianGro
Copy link
Member

When translating substitution handlers from shared.rst through Weblate, one might think that this should break pages that include said substitution if its handler has not been translated as well (and the strings don't match).

Apparently includes are run before gettext (sphinx-doc/sphinx#1587 (comment)).
This doesn't explain why gettext seemingly things that strings from shared.rst are only in shared.rst, and not also in files that include shared.rst.
It also doesn't explain why the translation for shared.rst seemingly does not get applied to files including shared.rst.

Another observation is that gettext strings for shared.rst do not contain a line number like for every other file.

While this is a non-issue, since shared.rst currently doesn't contain anything that actually needs to be translated; This might or might not become a problem if we try to use includes for strings that actually need translation.

@JulianGro JulianGro added the bug Something isn't working label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant