-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for pack to be downloaded as a zip file #37
Comments
The current release does actually have code to handle modpacks in zip files! But it was only ever used when downloading Github zipballs (which never actually worked), and I decided to remove this code when rewriting it. I'm happy to add support for zip files again if there are sufficient use cases (Modrinth mrpack support is another one); though I want to add direct support for Git repositories which should avoid this issue - Git can create packfiles which significantly reduce the number of HTTP requests required. I'm switching to Okio in the next release, which has connection pooling and might be better at not triggering the DDOS protection anyway. I'll be releasing this shortly, do let me know if it helps! |
Sounds great. I'll keep you posted when the release comes. |
Just tried the newest update, and from some preliminary testing, it seems all good now! Thank you for this. I'm not entirely sure if you want this issue to be closed as you may still want to add zip support and this could serve as a reminder of sorts. I'll leave it up to you. |
Nice! I'll leave this issue open for now; if there are other use cases people find it'd be helpful to keep them in one place. |
I have just found Packwiz and I think it's a great tool. But I've had one issue with putting this into production.
I have hosted the pack on my web server but as it's behind DDoS protection, the connection is being reset due to the amount of requests being sent when downloading the mod toml files.
To mitigate this you could add an option to download the pack as one zip blob.
The text was updated successfully, but these errors were encountered: