Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for pack to be downloaded as a zip file #37

Open
AnthonyFuller opened this issue Jul 15, 2022 · 4 comments
Open

Allow for pack to be downloaded as a zip file #37

AnthonyFuller opened this issue Jul 15, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@AnthonyFuller
Copy link

I have just found Packwiz and I think it's a great tool. But I've had one issue with putting this into production.

I have hosted the pack on my web server but as it's behind DDoS protection, the connection is being reset due to the amount of requests being sent when downloading the mod toml files.

To mitigate this you could add an option to download the pack as one zip blob.

@AnthonyFuller AnthonyFuller changed the title Allow for pack to be downloaded with a zip file Allow for pack to be downloaded as a zip file Jul 15, 2022
@comp500
Copy link
Member

comp500 commented Jul 15, 2022

The current release does actually have code to handle modpacks in zip files! But it was only ever used when downloading Github zipballs (which never actually worked), and I decided to remove this code when rewriting it. I'm happy to add support for zip files again if there are sufficient use cases (Modrinth mrpack support is another one); though I want to add direct support for Git repositories which should avoid this issue - Git can create packfiles which significantly reduce the number of HTTP requests required.

I'm switching to Okio in the next release, which has connection pooling and might be better at not triggering the DDOS protection anyway. I'll be releasing this shortly, do let me know if it helps!

@AnthonyFuller
Copy link
Author

Sounds great. I'll keep you posted when the release comes.

@AnthonyFuller
Copy link
Author

Just tried the newest update, and from some preliminary testing, it seems all good now! Thank you for this.

I'm not entirely sure if you want this issue to be closed as you may still want to add zip support and this could serve as a reminder of sorts. I'll leave it up to you.

@comp500
Copy link
Member

comp500 commented Jul 16, 2022

Nice! I'll leave this issue open for now; if there are other use cases people find it'd be helpful to keep them in one place.

@comp500 comp500 added the enhancement New feature or request label Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants