Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request / out-of-spec regression] Relative URIs starting with .. no longer work in metadata files #40

Open
dragonmaus opened this issue Jul 17, 2022 · 3 comments · May be fixed by #83
Labels
enhancement New feature or request

Comments

@dragonmaus
Copy link

In pre-0.5.0 versions, the HTTP resolver would "correctly" parse relative URIs starting with ../. Version 0.5.0 throws an IllegalArgumentException when it encounters such entries.

Example:
http://example.com/packwiz-repo/config/Adorn.json5.toml

name = "config/Adorn.json5"
filename = "Adorn.json5"
side = "both"

[download]
url = "../files/config/Adorn.json5"
hash-format = "sha256"
hash = "cd7e9a0b0248131ee7923eb63a9a61f41efbe57ee6b0919c003693ecba52a6ae"

v0.4.3 resolves url to http://example.com/packwiz-repo/files/config/Adorn.json5
v0.5.0 throws java.lang.IllegalArgumentException: Expected URL scheme 'http' or 'https' but no scheme was found for ../fil...

@comp500 comp500 added the enhancement New feature or request label Jul 17, 2022
@Dakedres
Copy link

Would also like to note that it would be nice if files refrenced by relative downloads were still hosted, even if they were targeted by the .packwizignore, so we could keep all of our pack in a single directory and not have users downloading files they're not using.

@dragonmaus
Copy link
Author

Would also like to note that it would be nice if files refrenced by relative downloads were still hosted, even if they were targeted by the .packwizignore, so we could keep all of our pack in a single directory and not have users downloading files they're not using.

This is the responsibility of whatever method you use to upload the files or otherwise set them up on the host. Packwiz doesn't have anything to do with what files are or are not hosted.

@Dakedres
Copy link

Dakedres commented Aug 5, 2022

I'm referring to packwiz serve, it does not serve files included in your .packwizignore

JordanPlayz158 added a commit to JordanPlayz158/packwiz-installer that referenced this issue Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants