Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IT Wallet): [SIW-1972] Remote presentation same device #6689

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

RiccardoMolinari95
Copy link
Collaborator

@RiccardoMolinari95 RiccardoMolinari95 commented Feb 5, 2025

Short description

This PR introduces the ability to start the remote presentation flow through a deep link in a same-device scenario.

List of changes proposed in this pull request

  • Updated useItwLinkingOptions to include linking options for remote deep link
  • Added buildItwRemoteRequestDeepLink function to construct a deep link using itwRemoteRequestPayload

How to test

The remote presentation QR code should be read normally

Note

I was unable to test the deep link functionality, as it seems to only work with the app downloaded from the store

Copy link
Contributor

github-actions bot commented Feb 5, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.90%. Comparing base (0684a82) to head (08153e0).

Files with missing lines Patch % Lines
...let/presentation/remote/Utils/itwRemoteUrlUtils.ts 62.50% 3 Missing ⚠️
ts/features/barcode/screens/BarcodeScanScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6689      +/-   ##
==========================================
- Coverage   49.91%   49.90%   -0.01%     
==========================================
  Files        1551     1551              
  Lines       32275    32279       +4     
  Branches     7298     7248      -50     
==========================================
  Hits        16109    16109              
- Misses      16127    16131       +4     
  Partials       39       39              
Files with missing lines Coverage Δ
ts/features/barcode/types/IOBarcode.ts 100.00% <ø> (ø)
ts/features/barcode/types/decoders.ts 96.66% <ø> (ø)
...tures/itwallet/navigation/useItwLinkingOptions.tsx 100.00% <ø> (ø)
...tion/remote/navigation/ItwRemoteStackNavigator.tsx 44.44% <ø> (ø)
ts/features/barcode/screens/BarcodeScanScreen.tsx 1.31% <0.00%> (ø)
...let/presentation/remote/Utils/itwRemoteUrlUtils.ts 62.50% <62.50%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0684a82...08153e0. Read the comment docs.

@RiccardoMolinari95 RiccardoMolinari95 marked this pull request as draft February 6, 2025 07:23
Base automatically changed from SIW-1960-scan-qr-code-remote-presentation to master February 6, 2025 14:02
Copy link

dpulls bot commented Feb 6, 2025

🎉 All dependencies have been resolved !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant