Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make multidev cleanup configurable #71

Open
dustinleblanc opened this issue Feb 21, 2024 · 2 comments
Open

Make multidev cleanup configurable #71

dustinleblanc opened this issue Feb 21, 2024 · 2 comments

Comments

@dustinleblanc
Copy link
Contributor

Hey folks! Another piece of feedback from my team on the Pantheon orb usage that I thought I'd share.

The build tools branch naming conventions and multidev management techniques (deleting stale multidevs to maintain space) are great sensible defaults, but they've seen some resistance among members of our team mostly for two reasons:

  1. They prefer to name multidevs after the ticket number (which is our branch name)
  2. They prefer to manually cleanup multidevs instead of having this automated (this is not a universal preference, but some see benefit in being able to access old multidevs after a project has shipped and there is a question about content/etc).

We would desire to be able to configure this behavior using orb parameters in a similar manner to the terminus clone environment, ability to not always clone content, etc.

This is another area where we could provide a pull request to implement if this feature were desirable, and it would again be backwards compatible by making the current behavior the default.

thanks!

@dustinleblanc dustinleblanc changed the title Make multidev delete configurable Make multidev naming/delete configurable Feb 21, 2024
@namespacebrian
Copy link

This is another area where we could provide a pull request to implement if this feature were desirable

@dustinleblanc yes, we like it. send us PRs :)

@dustinleblanc dustinleblanc changed the title Make multidev naming/delete configurable Make multidev cleanup configurable Mar 29, 2024
@dustinleblanc
Copy link
Contributor Author

I've pivoted on this bit after looking at the code, it looks like changing the multidev naming scheme will require deeper work in the internals of the build-tools-plugin as the naming patterns are hard-coded there. It is much easier to just make the cleanup op disableable so I have a branch that I am planning to PR that does just that, same backwards compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants