Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Getting started" docs show two levels of expanders #16

Closed
huonw opened this issue Dec 30, 2023 · 3 comments · Fixed by #38
Closed

"Getting started" docs show two levels of expanders #16

huonw opened this issue Dec 30, 2023 · 3 comments · Fixed by #38
Labels
bug Something isn't working
Milestone
Switch-over

Comments

@huonw
Copy link
Contributor

huonw commented Dec 30, 2023

From #4:

There's two levels of expanders for "Getting started": https://docs.pantsbuild.org/2.18.x/docs/getting-started/getting-started
image
@thejcannon
Copy link
Member

To be fair, this is how it's structured in the existing docs site...

Screenshot from 2023-12-30 06-45-45

@huonw
Copy link
Contributor Author

huonw commented Dec 30, 2023

Ah, I see... just fewer clicks/less obvious with how readme does the section headers.

@thejcannon
Copy link
Member

We can and should fix this, just noting that it's inherited from the current docs site

@huonw huonw added this to the Switch-over milestone Dec 31, 2023
@huonw huonw added the bug Something isn't working label Dec 31, 2023
@thejcannon thejcannon mentioned this issue Jan 2, 2024
Merged
thejcannon added a commit that referenced this issue Jan 2, 2024
@thejcannon
Un-nest "Getting-Started" (#38)
1a6ddcd 
Fixes #16 by
un-nesting `getting-started/getting-started` into just
`getting-started`, and adjusting all of the references.

Fixed across all relevant versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Switch-over
Development

Successfully merging a pull request may close this issue.

Un-nest "Getting-Started" pantsbuild/pantsbuild.org
2 participants
@huonw @thejcannon