Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not post inc the ip #2

Open
evanxg852000 opened this issue Jul 26, 2019 · 2 comments
Open

Should not post inc the ip #2

evanxg852000 opened this issue Jul 26, 2019 · 2 comments

Comments

@evanxg852000
Copy link

ip = code[ip++];

The ip should not be moved forward after updating it
ip = code[ip];

@parrt
Copy link
Owner

parrt commented Jul 26, 2019

Ah good point. That's a waste of an increment. no doubt I was just being consistent or maybe it was a cut-and-paste error . haha

@evanxg852000
Copy link
Author

👍 But again thanks for the work in compilers. Especially the book "Language Implementation Patterns" I got it back in 2011 and still read it today. I was actually revisiting this talk and implementing the svm while learning rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants