Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watched pattern.json does not trigger a re-render of its pattern #790

Closed
bmuenzenmeyer opened this issue Jan 29, 2018 · 1 comment
Closed

Comments

@bmuenzenmeyer
Copy link
Member

I am using Pattern Lab Node v3.0.0-alpha.7 on Windows, with Node v8.9.3, using the Gulp Edition.

Found while troubleshooting pattern-lab/edition-node-gulp#119

Expected Behavior

gulp patternlab:serve builds patterns, starts watching files
Editing btn.json to Test Edit should reveal the new value after a render

Actual Behavior

patternlab-pattern-change is emitted, but the file emitted is C:\\src\\edition-node-gulp\\source\\_patterns\\atoms\\buttons\\btn.json which will not map to any file to mark for re-write

Steps to Reproduce

cleanPublic set to false, enabling incremental builds,

btn.mustache

{{ text }}

btn.json

{
  "text": "Test"
}
@mbulfair
Copy link

@bmuenzenmeyer This issue also seems to be in the 2.x branch. The only work around is to set cleanPublic to true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants