Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bo kc issue ui backend #33

Closed
wants to merge 14 commits into from
Closed

Bo kc issue ui backend #33

wants to merge 14 commits into from

Conversation

RealDogDad
Copy link
Collaborator

Connects Create Account UI to Create Account DB
Allows for the creation of multiple Accounts in the DB
The Accounts are now reflected in the Main Dashboard

Copy link
Collaborator

@Dylan-Riley Dylan-Riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out branch on my machine and worked as you demoed earlier today. Buttons for withdraw and deposit are still weirdly offset on my screen, I'll add that as something to look into more myself

@jleeboyd
Copy link
Collaborator

jleeboyd commented Nov 2, 2020

@theanticrumpet What emulator are you using?

Copy link
Collaborator

@jleeboyd jleeboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on Entity code. Otherwise looks good

@Entity(foreignKeys = @ForeignKey(entity = AccountEntity.class,
parentColumns = "accountUid",
childColumns = "transactionUid",
onDelete = ForeignKey.CASCADE))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using this? The same code is already created in the AccountWithTransactions activity.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@26ff124). Click here to learn what that means.
The diff coverage is 17.39%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage          ?   12.31%           
  Complexity        ?       10           
=========================================
  Files             ?       15           
  Lines             ?      276           
  Branches          ?        1           
=========================================
  Hits              ?       34           
  Misses            ?      240           
  Partials          ?        2           
Impacted Files Coverage Δ Complexity Δ
...a/com/example/family_bank_app/AccountActivity.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ava/com/example/family_bank_app/AccountEntity.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../com/example/family_bank_app/AccountViewModel.java 17.64% <ø> (ø) 2.00 <0.00> (?)
.../java/com/example/family_bank_app/AppDatabase.java 100.00% <ø> (ø) 1.00 <0.00> (?)
.../example/family_bank_app/MyTransactionAdapter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...m/example/family_bank_app/TransactionActivity.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...com/example/family_bank_app/TransactionEntity.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/com/example/family_bank_app/MainActivity.java 46.15% <36.00%> (ø) 3.00 <1.00> (?)
.../com/example/family_bank_app/MyAccountAdapter.java 23.33% <37.50%> (ø) 2.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ff124...3fb1ff0. Read the comment docs.

@jleeboyd jleeboyd closed this Nov 11, 2020
@jleeboyd jleeboyd deleted the BO-KC-Issue-UI-Backend branch December 9, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants