Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up models_require.rb #62

Open
paulrayner opened this issue Sep 17, 2014 · 0 comments
Open

Tidy up models_require.rb #62

paulrayner opened this issue Sep 17, 2014 · 0 comments

Comments

@paulrayner
Copy link
Owner

The file spec/support/models_require.rb is used by some of the specs to require the domain objects. There must be a better way to do this. Plus, when new files are added it's just another file to update that could slip through the cracks.

I just added routing_service to this file, which makes it even more poorly named. Rails calls these objects 'models' but they are not. There is only one domain model in this application for cargo tracking, and it includes all the objects in this file. Each object is not its own model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant