From 3bcb8ebbf37064a8734438ee65d6181fffbd908f Mon Sep 17 00:00:00 2001 From: Victoria Park Date: Mon, 26 Feb 2024 08:33:07 -0800 Subject: [PATCH] Sammy pr feedback --- CHANGELOG.md | 2 +- Demo/Demo/ViewModels/CardVaultViewModel.swift | 2 +- Sources/CardPayments/CardClient.swift | 2 +- Sources/CardPayments/CardVaultDelegate.swift | 4 ++-- UnitTests/CardPaymentsTests/CardClient_Tests.swift | 3 +-- UnitTests/CardPaymentsTests/Mocks/MockCardVaultDelegate.swift | 2 +- 6 files changed, 7 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 933feee50..6b1ceef8e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ * Support VoiceOver by adding button accessibility labels * Font typeface changed to "PayPalOpen" to meet brand guidelines * CardPayments - * Add `cardDidCancelVault()` to `CardVaultDelegate` + * Add `cardDidCancelThreeDSecure()` to `CardVaultDelegate` * Add `cardThreeDSecureWillLaunch()` to `CardVaultDelegate` * Add `cardThreeDSecureDidFinish()` to `CardVaultDelegate` * PayPalWebPayments diff --git a/Demo/Demo/ViewModels/CardVaultViewModel.swift b/Demo/Demo/ViewModels/CardVaultViewModel.swift index 445b073b2..ca19d22d7 100644 --- a/Demo/Demo/ViewModels/CardVaultViewModel.swift +++ b/Demo/Demo/ViewModels/CardVaultViewModel.swift @@ -59,7 +59,7 @@ class CardVaultViewModel: VaultViewModel, CardVaultDelegate { setUpdateSetupTokenResult(vaultError: vaultError) } - func cardDidCancelVault(_ cardClient: CardClient) { + func cardDidCancelThreeDSecure(_ cardClient: CardClient) { DispatchQueue.main.async { self.state.updateSetupTokenResponse = .idle self.state.updateSetupToken = nil diff --git a/Sources/CardPayments/CardClient.swift b/Sources/CardPayments/CardClient.swift index a475d85c2..604fbef88 100644 --- a/Sources/CardPayments/CardClient.swift +++ b/Sources/CardPayments/CardClient.swift @@ -204,7 +204,7 @@ public class CardClient: NSObject { } private func notifyVaultCancellation() { - vaultDelegate?.cardDidCancelVault(self) + vaultDelegate?.cardDidCancelThreeDSecure(self) } } diff --git a/Sources/CardPayments/CardVaultDelegate.swift b/Sources/CardPayments/CardVaultDelegate.swift index 3d45096be..2676b31ce 100644 --- a/Sources/CardPayments/CardVaultDelegate.swift +++ b/Sources/CardPayments/CardVaultDelegate.swift @@ -18,10 +18,10 @@ public protocol CardVaultDelegate: AnyObject { /// - didFinishWithError: the error returned by the Card vault flow func card(_ cardClient: CardClient, didFinishWithVaultError vaultError: CoreSDKError) - /// Notify that the Card vault flow has been cancelled + /// Notify that the ThreeDSecure has been cancelled /// - Parameters: /// - client: the CardClient associated with delegate - func cardDidCancelVault(_ cardClient: CardClient) + func cardDidCancelThreeDSecure(_ cardClient: CardClient) /// Notify that the 3DS challenge will be launched /// - Parameters: diff --git a/UnitTests/CardPaymentsTests/CardClient_Tests.swift b/UnitTests/CardPaymentsTests/CardClient_Tests.swift index 29b4ded9e..a25f1938c 100644 --- a/UnitTests/CardPaymentsTests/CardClient_Tests.swift +++ b/UnitTests/CardPaymentsTests/CardClient_Tests.swift @@ -5,8 +5,7 @@ import AuthenticationServices @testable import CardPayments @testable import TestShared -// swiftlint:disable type_body_length -// swiftlint:disable file_length +// swiftlint:disable type_body_length file_length class CardClient_Tests: XCTestCase { // MARK: - Helper Properties diff --git a/UnitTests/CardPaymentsTests/Mocks/MockCardVaultDelegate.swift b/UnitTests/CardPaymentsTests/Mocks/MockCardVaultDelegate.swift index 42fa9e251..abe51d991 100644 --- a/UnitTests/CardPaymentsTests/Mocks/MockCardVaultDelegate.swift +++ b/UnitTests/CardPaymentsTests/Mocks/MockCardVaultDelegate.swift @@ -31,7 +31,7 @@ class MockCardVaultDelegate: CardVaultDelegate { failure?(cardClient, vaultError) } - func cardDidCancelVault(_ cardClient: CardClient) { + func cardDidCancelThreeDSecure(_ cardClient: CardClient) { cancel?(cardClient) }