Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate conflicts between Vaadin and Spring Security #203

Open
peholmst opened this issue Mar 4, 2015 · 10 comments
Open

Investigate conflicts between Vaadin and Spring Security #203

peholmst opened this issue Mar 4, 2015 · 10 comments

Comments

@peholmst
Copy link
Owner

peholmst commented Mar 4, 2015

There are a few things such as CSRF protection and session management that both Vaadin and Spring Security try to handle. This can lead to conflicts and strange errors. We have to investigate what features are duplicated and how to handle them.

@gjrtimmer
Copy link
Collaborator

For CSRF, I've opted in all samples to disable its' use within Spring Security. What kind of strange errors are you getting ?

I believe only one should be enabled.

@pesse
Copy link
Contributor

pesse commented Mar 5, 2015

My experience is also that you should just disable Spring Security CSRF protection when using Vaadin4Spring. Since I did, everything seems to work pretty well in my current project.

@peholmst
Copy link
Owner Author

peholmst commented Mar 5, 2015

We've experienced push stability problems with Spring Security. Sometimes, the UI freezes and you have to do a hard refresh to get a new UI. We don't know what's causing this, but one possibility is that Spring Security does something with the session that is not compatible with Vaadin push.

@gjrtimmer
Copy link
Collaborator

Do you have some reproduction steps for me ?

@peholmst
Copy link
Owner Author

peholmst commented Mar 5, 2015

No we don't, this problem is completely random. We have not been able to reproduce it, but still it happens every now and then. However, sometimes, we've seen this message in the logs: "Session expired before push was disconnected. This should never happen."

@monp
Copy link

monp commented Mar 5, 2015

The FileDownloader extension is not working with "frameOptions" enabled. I've also experienced some problems with push months ago, I've figured out that web filters were completely ignored by push requests.. That's maybe a clue.

@peholmst
Copy link
Owner Author

peholmst commented Mar 5, 2015

@monp What transport protocol were you using for push? Websockets, long polling or streaming?

@monp
Copy link

monp commented Mar 5, 2015

It was Websockets... that's probably why ^^.

@peholmst
Copy link
Owner Author

peholmst commented Mar 5, 2015

@monp OK. The problems we're experiencing show up when using long polling.

This was referenced Mar 17, 2015
@FearlessHyena
Copy link
Contributor

doesn't Vaadin have CSRF protection built-in? If so would there be any need to enable csrf on the Spring WebSecurityConfigurerAdapter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants