Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12 build? #7

Open
DaComputerNerd717 opened this issue Jul 18, 2019 · 14 comments
Open

1.12 build? #7

DaComputerNerd717 opened this issue Jul 18, 2019 · 14 comments

Comments

@DaComputerNerd717
Copy link

I see the 1.12 source in the repository. Is there a 1.12 build? Also, where am I supposed to get any builds, the minecraftforum page is down

@percivalalb
Copy link
Owner

I never released any builds above 1.7 unfortunately. The 1.12 version works fine I believe, but have not tested, if u want to compile it and use it personally go ahead. I will see about moving downloads to curseforge.

@DaComputerNerd717
Copy link
Author

DaComputerNerd717 commented Jul 18, 2019

I also had some ideas that I may try and add as well, like OpenComputers interaction, and lasers being filtered by colored glass (plus maybe a config to add other mod's colored glass blocks to the list) or possibly having a filter block, and also an idea inspired by Nuclearcraft's MSR vessels, where shift clicking one reflector onto another copies the state of each side

@DaComputerNerd717
Copy link
Author

DaComputerNerd717 commented Jul 18, 2019

what forge version is it built against? I have a number of errors when importing into my workspace

nvm, fixed the errors in updating to 2838

@percivalalb
Copy link
Owner

Committed everything I have, no idea if it works or not :P

@DaComputerNerd717
Copy link
Author

DaComputerNerd717 commented Jul 21, 2019

I had already done some work on it, so I may have to merge it. There is OpenComputers interaction on the laser detector now. However, I have found a bug, where, if the last side of a reflector to be opened did not have a laser going into it, the reflector would immediately have a nonexistent red laser coming in at the bottom, regardless of whether the bottom is open or not, and ignore all other inputs. As a result, it then outputs the red laser at all open sides regardless of whether or not there is an input laser on it. I don't believe I've made any changes that would cause this.

@DaComputerNerd717
Copy link
Author

2019-07-21_10 40 30

@percivalalb
Copy link
Owner

I think that is something that is fixed in the commit

@DaComputerNerd717
Copy link
Author

I guess I'll have to merge, then

@DaComputerNerd717
Copy link
Author

I had to merge manually due to how I did this, the OpenComputers interaction for laser detectors is done. I think maybe I'll let it control open sides on reflectors as well.

@DaComputerNerd717
Copy link
Author

The new commit did fix it

@DaComputerNerd717
Copy link
Author

DaComputerNerd717 commented Jul 22, 2019

making progress
2019-07-22_09 15 19

@DaComputerNerd717
Copy link
Author

I've added all of those ideas I mentioned earlier except the filtering so far.

@DaComputerNerd717
Copy link
Author

DaComputerNerd717 commented Jul 23, 2019

I can't figure out the filtering, I guess I'll commit what I have and you can see what you can do.
I had been copying the color converter to a new laser filter block, but it didn't work, crashing when placed. I commented out where I added it to the GameRegistry, so it won't cause issues.

How do we want to merge everything back in?

@percivalalb
Copy link
Owner

Create a merge request but can't promise I'll have time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants