-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of If-Match: * is not RFC compliant #483
Comments
Thank you for raising this issue. |
It is also specified in RFC 2616, issued at June 1999 and obsoleted by RFC 7232 later.
https://tools.ietf.org/html/rfc2616#section-14.24 RFC 2068, which is predecessor of RFC 2616 and released at January 1997, also states the same behavior. https://tools.ietf.org/html/rfc2068#section-14.25 So, Personium had been violating the RFC from beginning. |
It is a shame we had been violating RFC2616 from the beginning. Thank you for pointing it out and give us a chance to stop this situation. Could you help us a bit more to make things clearer? My understanding is the following: ConditionsWhen the following 3 conditions are met:
Current Personium:
To make it RFC compliant, it should:
Is my understanding correct? |
Yes. It must return 412. |
|
In my opinion, the priority of this bug isn't high. Practical applications won't pass |
Moved to 1.7.21 for the issue personium/personium-engine#119. |
The documentation says if we omit
If-Match
header for WebDAVPUT
method, it defaults to*
.https://personium.io/docs/en/apiref/current/312_Register_and_Update_WebDAV.html
This is not compliant to RFC 7232:
https://tools.ietf.org/html/rfc7232#section-3.1
Omitting
If-Match
header and givingIf-Match
header with the value*
must behave differently.I have not checked actual behavior. Is this just a error of documentation, or bug of actual implementation?
The text was updated successfully, but these errors were encountered: