We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think it would be nice if I can write Engine Script Handler as module.
For example,
const { something } = require("./submodule"); exports.handler = function(request) { const result = something.do(); return { status: 200, headers: {"Content-Type": "application/json"}, body: [ JSON.stringify(result)], }; };
Current part of calling function is below.
https://github.com/personium/personium-engine/blob/develop/src/main/java/io/personium/engine/PersoniumEngineContext.java#L367
Object fObj = scope.get("fn_jsgi", scope); Object result = null; if (!(fObj instanceof Function)) { log.warn("fn_jsgi not found"); throw new PersoniumEngineException("Server Error", PersoniumEngineException.STATUSCODE_SERVER_ERROR); } Object[] functionArgs = {jsReq.getRequestObject() }; previousPhaseTime = System.currentTimeMillis(); Function f = (Function) fObj; result = f.call(cx, scope, scope, functionArgs);
I think this issue could be solved with modifing here with below steps.
loadedmodule.handler
Merits
the handle function must be written on first place
Demerits
How is this?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I think it would be nice if I can write Engine Script Handler as module.
For example,
Current part of calling function is below.
https://github.com/personium/personium-engine/blob/develop/src/main/java/io/personium/engine/PersoniumEngineContext.java#L367
I think this issue could be solved with modifing here with below steps.
loadedmodule.handler
Merits
The script which is written in module style can be import easily from local.
The rule
the handle function must be written on first place
Demerits
How is this?
The text was updated successfully, but these errors were encountered: