Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the execution order of tasks that create unitadmin_account #26

Open
KourokiTakuto opened this issue Dec 11, 2018 · 3 comments
Open
Assignees
Labels

Comments

@KourokiTakuto
Copy link
Contributor

KourokiTakuto commented Dec 11, 2018

Overview
Required unitadmin_account is not created if optional task fails

Hot Fixes
If an optional task fails, it is better to generate logs and messages (how to solve the problem) and proceed to the next task.

Repletion
The current vagrant carries out the following optional tasks (Git cloning, construction, deployment) separately from the existing ansible.
httpclient ← Required
mailsender ← Option
slack messenger ← Required
ew services ← Required
unit-manager ← Option
Other apps ← Option

@dixonsiu
Copy link
Member

Changing the order will not solve similar problem. It should be done the right way.

Suggestion

  1. Execute an optional task and check the result.
  2. If it fails, produce log and message (how to fix the problem).
  3. Execute other task.

Advance
Should use the Cell Import feature to setup the App Cell.

@KourokiTakuto
Copy link
Contributor Author

Since we modified the App cell to use cell import function, correspondence of advance part is unnecessary.
https://github.com/personium/setup-vagrant/pull/28/files

@KourokiTakuto
Copy link
Contributor Author

KourokiTakuto commented Dec 25, 2018

The option or required is described below:

  1. httpclient : Required
  2. mailsender : Optional
  3. slack messenger : Required
  4. ew services : Required
  5. unit-manager : Optional
  6. Other application : Optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants