only write the opening '[' after the first object is received #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriszyp
added a commit
that referenced
this pull request
Feb 25, 2015
only write the opening '[' after the first object is received
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have an issue only in IE11 where i'm using long-polling for messages/json content and when the request times out i get responses containing
[instead of an empty response. i think https://github.com/persvr/pintura/blob/master/media/json.js#L31-L37 is the cause and i'm wondering ifwrite("[")should be inside theif(first)block. thefirstvariable there seems to imply that might be the intention and it's not doing anything else.this PR makes that change.