Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to handle character encodings and illegal filename characters #2

Open
pieper opened this issue Apr 18, 2013 · 1 comment
Open

Comments

@pieper
Copy link
Owner

pieper commented Apr 18, 2013

Likely most reliable option is map everything to the C Locale and ascii encoding for broadest compatibility with filesystems. Also can search and replace characters like colon, which is invalid on windows as well as slash and backslash.

@pieper
Copy link
Owner Author

pieper commented Apr 26, 2013

Currently the code is removing characters that are known to be illegal in filenames on various target platforms (like slash and colon).

It's an open question if different character encodings should be converted, since most OS filesystems can handle unicode filenames, so if the dicom file has a patient name with an accented character for example, it should be valid to create a filename with the same character.

To know for sure we would need to find sample dicom data containing a variety of character strings and confirm it works for our target operating systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant