Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally warn about unsaved changes #116

Open
anewuser opened this issue Aug 7, 2022 · 2 comments
Open

Optionally warn about unsaved changes #116

anewuser opened this issue Aug 7, 2022 · 2 comments

Comments

@anewuser
Copy link
Contributor

anewuser commented Aug 7, 2022

Some users might appreciate a warning before leaving the editor page with unsaved changes, as in this example:

uBlock Origin

If you decide to implement this, though, please make it optional. Personally, I'd disable it, since I'm used to opening different pipes just to check or copy something. I consciously close editor tabs and expect this to undo any accidental changes.

@onli
Copy link
Member

onli commented Sep 18, 2022

Hm. That it should be disabled makes me think it might not be the right solution for the data loss problem.

Wouldn't this be better: Save the temporary changes in the browser and restore them when going back to the canves, iff it is exactly the same pipe? Probably should be combined with a marker for which changes are not saved yet (something in the block title?).

@anewuser
Copy link
Contributor Author

anewuser commented Sep 18, 2022

Yes, your idea is less intrusive. What about also adding an option to revert all changes that have been done locally to the canvas since the last time the pipe was saved? If you like this idea, maybe you can also move the save and Pipe Output links to the top, since they aren't visible when all block categories are expanded (on resolutions equal or smaller than 1920×1080):

Screenshot Pipes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants