Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module fails to build for Linux 6.11 #190

Open
anbe42 opened this issue Sep 13, 2024 · 3 comments · May be fixed by #194
Open

Module fails to build for Linux 6.11 #190

anbe42 opened this issue Sep 13, 2024 · 3 comments · May be fixed by #194
Assignees
@pkoutoupis
Labels
bug enhancement

Comments

@anbe42
Copy link
Contributor

anbe42 commented Sep 13, 2024 

DKMS make.log for rapiddisk-9.1.0 for kernel 6.11-rc5-amd64 (x86_64)
Thu Sep 12 11:51:16 UTC 2024
make: Entering directory '/usr/src/linux-headers-6.11-rc5-amd64'
  CC [M]  /var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.o
  CC [M]  /var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk-cache.o
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk-cache.c:166:5: warning: no previous prototype for 'dm_io_async_bvec' [-Wmissing-prototypes]
  166 | int dm_io_async_bvec(unsigned int num_regions, struct dm_io_region *where,
      |     ^~~~~~~~~~~~~~~~
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk-cache.c:260:6: warning: no previous prototype for 'rc_io_callback' [-Wmissing-prototypes]
  260 | void rc_io_callback(unsigned long error, void *context)
      |      ^~~~~~~~~~~~~~
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk-cache.c:376:5: warning: no previous prototype for 'rc_do_complete' [-Wmissing-prototypes]
  376 | int rc_do_complete(struct kcached_job *job)
      |     ^~~~~~~~~~~~~~
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk-cache.c:418:6: warning: no previous prototype for 'kcached_client_destroy' [-Wmissing-prototypes]
  418 | void kcached_client_destroy(struct cache_context *dmc)
      |      ^~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk-cache.c:826:5: warning: no previous prototype for 'rc_map' [-Wmissing-prototypes]
  826 | int rc_map(struct dm_target *ti, struct bio *bio)
      |     ^~~~~~
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk-cache.c:1274:12: warning: no previous prototype for 'rc_init' [-Wmissing-prototypes]
 1274 | int __init rc_init(void)
      |            ^~~~~~~
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk-cache.c:1294:6: warning: no previous prototype for 'rc_exit' [-Wmissing-prototypes]
 1294 | void rc_exit(void)
      |      ^~~~~~~
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.c: In function 'attach_device':
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.c:824:9: error: implicit declaration of function 'blk_queue_logical_block_size'; did you mean 'queue_logical_block_size'? [-Wimplicit-function-declaration]
  824 |         blk_queue_logical_block_size(disk->queue, BYTES_PER_SECTOR);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         queue_logical_block_size
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.c:825:9: error: implicit declaration of function 'blk_queue_physical_block_size'; did you mean 'queue_physical_block_size'? [-Wimplicit-function-declaration]
  825 |         blk_queue_physical_block_size(disk->queue, PAGE_SIZE);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         queue_physical_block_size
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.c:832:9: error: too many arguments to function 'blk_queue_write_cache'
  832 |         blk_queue_write_cache(disk->queue, false, false);
      |         ^~~~~~~~~~~~~~~~~~~~~
In file included from /var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.c:30:
/usr/src/linux-headers-6.11-rc5-common/include/linux/blkdev.h:1322:20: note: declared here
 1322 | static inline bool blk_queue_write_cache(struct request_queue *q)
      |                    ^~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.c:848:9: error: implicit declaration of function 'blk_queue_max_discard_sectors'; did you mean 'bdev_max_discard_sectors'? [-Wimplicit-function-declaration]
  848 |         blk_queue_max_discard_sectors(disk->queue, 0);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         bdev_max_discard_sectors
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.c:852:28: error: 'QUEUE_FLAG_NONROT' undeclared (first use in this function); did you mean 'QUEUE_FLAG_NOMERGES'?
  852 |         blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
      |                            ^~~~~~~~~~~~~~~~~
      |                            QUEUE_FLAG_NOMERGES
/var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.c:852:28: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [/usr/src/linux-headers-6.11-rc5-common/scripts/Makefile.build:249: /var/lib/dkms/rapiddisk/9.1.0/build/rapiddisk.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/usr/src/linux-headers-6.11-rc5-common/Makefile:1950: /var/lib/dkms/rapiddisk/9.1.0/build] Error 2
make: *** [/usr/src/linux-headers-6.11-rc5-common/Makefile:236: __sub-make] Error 2
make: Leaving directory '/usr/src/linux-headers-6.11-rc5-amd64'

blk_queue_logical_block_size etc. were removed in Linux v6.11-rc1 by torvalds/linux@1652b0b

QUEUE_FLAG_NONROT was replaced in Linux v6.11-rc1 by torvalds/linux@bd4a633
@Augusto7743
Copy link

Only reporting information.
I have done an test in kernel liquorix 6.11 and not is possible compile being showed the errors below

make -C module
make[1]: Entering directory '/home/user/rd/module'
make -C /lib/modules/6.11.5-1-liquorix-amd64/build M=/home/user/rd/module
make[2]: Entering directory '/usr/src/linux-headers-6.11.5-1-liquorix-amd64'
CC [M] /home/user/rd/module/rapiddisk.o
/home/user/rd/module/rapiddisk.c: In function ‘attach_device’:
/home/user/rd/module/rapiddisk.c:824:9: error: implicit declaration of function ‘blk_queue_logical_block_size’; did you mean ‘queue_logical_block_size’? [-Werror=implicit-function-declaration]
824 | blk_queue_logical_block_size(disk->queue, BYTES_PER_SECTOR);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| queue_logical_block_size
/home/user/rd/module/rapiddisk.c:825:9: error: implicit declaration of function ‘blk_queue_physical_block_size’; did you mean ‘queue_physical_block_size’? [-Werror=implicit-function-declaration]
825 | blk_queue_physical_block_size(disk->queue, PAGE_SIZE);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| queue_physical_block_size
/home/user/rd/module/rapiddisk.c:832:9: error: too many arguments to function ‘blk_queue_write_cache’
832 | blk_queue_write_cache(disk->queue, false, false);
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /home/user/rd/module/rapiddisk.c:30:
./include/linux/blkdev.h:1322:20: note: declared here
1322 | static inline bool blk_queue_write_cache(struct request_queue *q)
| ^~~~~~~~~~~~~~~~~~~~~
/home/user/rd/module/rapiddisk.c:848:9: error: implicit declaration of function ‘blk_queue_max_discard_sectors’; did you mean ‘bdev_max_discard_sectors’? [-Werror=implicit-function-declaration]
848 | blk_queue_max_discard_sectors(disk->queue, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| bdev_max_discard_sectors
/home/user/rd/module/rapiddisk.c:852:28: error: ‘QUEUE_FLAG_NONROT’ undeclared (first use in this function); did you mean ‘QUEUE_FLAG_NOMERGES’?
852 | blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
| ^~~~~~~~~~~~~~~~~
| QUEUE_FLAG_NOMERGES
/home/user/rd/module/rapiddisk.c:852:28: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:244: /home/user/rd/module/rapiddisk.o] Error 1
make[3]: *** [/usr/src/linux-headers-6.11.5-1-liquorix-amd64/Makefile:1937: /home/user/rd/module] Error 2
make[2]: *** [Makefile:224: __sub-make] Error 2
make[2]: Leaving directory '/usr/src/linux-headers-6.11.5-1-liquorix-amd64'
make[1]: *** [Makefile:37: all] Error 2
make[1]: Leaving directory '/home/user/rd/module'
make: *** [Makefile:29: module] Error 2

@pkoutoupis pkoutoupis self-assigned this Nov 14, 2024
@pkoutoupis
Copy link
Owner

Ok. Thank you. I will need to look into this.

@pkoutoupis
Copy link
Owner

@anbe42 and @Augusto7743 Are you building master? If not, can you please try master?

@anbe42 anbe42 linked a pull request Feb 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkoutoupis pkoutoupis

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Linux 6.11 support anbe42/rapiddisk
3 participants
@anbe42 @pkoutoupis @Augusto7743