Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply MagicOnion.Server.OpenTelemetry #1848

Closed
moreal opened this issue Jan 25, 2023 · 3 comments · Fixed by #2499
Closed

Apply MagicOnion.Server.OpenTelemetry #1848

moreal opened this issue Jan 25, 2023 · 3 comments · Fixed by #2499
Assignees
@moreal
Labels
observability Issues, pull requests related to Observability suggestion Suggestion something

Comments

@moreal
Copy link
Contributor

moreal commented Jan 25, 2023

No description provided.

@moreal moreal self-assigned this Jan 25, 2023
@moreal
Copy link
Contributor Author

moreal commented Jan 26, 2023

Now, NineChronicles.Headless cannot apply MagicOnion.Server.OpenTelemetry because there are conflict for Microsoft.Extensions.Logging package between OpenTelemetry and Sentry.AspNetCore.Grpc.

/path/to/NineChronicles.Headless/NineChronicles.Headless.Executable/NineChronicles.Headless.Executable.csproj : error NU1107:  NineChronicles.Headless.Executable -> Sentry.AspNetCore.Grpc 3.22.0 -> Sentry.AspNetCore 3.22.0 -> Sentry.Extensions.Logging 3.22.0 -> Microsoft.Extensions.Logging.Configuration 6.0.0 -> Microsoft.Extensions.Logging (>= 6.0.0)  [/path/to/planetarium/NineChronicles.Headless/NineChronicles.Headless.Executable.sln]
/path/to/NineChronicles.Headless/NineChronicles.Headless.Executable/NineChronicles.Headless.Executable.csproj : error NU1107:  NineChronicles.Headless.Executable -> NineChronicles.Headless -> MagicOnion.Server.OpenTelemetry 5.0.3-beta2-1.1.0 -> OpenTelemetry 1.1.0-beta2 -> Microsoft.Extensions.Logging (>= 2.1.0 && < 6.0.0). [/path/to/NineChronicles.Headless/NineChronicles.Headless.Executable.sln]

So I opened the pull request to bump OpenTelemetry but I'm not sure it'll be accepted or not.
Cysharp/MagicOnion#608

@moreal
Copy link
Contributor Author

moreal commented Jan 26, 2023

The above issue can be resolved by adding Microsoft.Extensions.Logging package dependency manually. But there is no metrics anymore so it should be recovered from previous versions of MagicOnion.OpenTelemetry. I did it in moreal@a368446 commit.

@moreal moreal moved this from Todo to In Progress in Nine Chronicles DX Team Jan 27, 2023
@moreal moreal moved this from In Progress to Todo in Nine Chronicles DX Team Jan 30, 2023
@moreal moreal added suggestion Suggestion something observability Issues, pull requests related to Observability labels Jul 26, 2023
@moreal moreal mentioned this issue Jul 15, 2024
Merged
@moreal
Copy link
Contributor Author

moreal commented Jul 15, 2024

The package is replaced with Metrics API in Cysharp/MagicOnion#692. This issue's goal may be achieved by #2499

@moreal moreal linked a pull request Jul 15, 2024 that will close this issue
Upgrade MaginOnion version to 6.1.3 #2499
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Nine Chronicles DX Team Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moreal moreal

Labels
observability Issues, pull requests related to Observability suggestion Suggestion something
Projects
Nine Chronicles DX Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade MaginOnion version to 6.1.3 sky1045/NineChronicles.Headless
1 participant
@moreal