Is "AbortVersioningOfLargeFilesAndImages" and "SkipVersioningOfLargeFilesAndImages" still needed for Dexterity's "File" blobs?

[idgserpro]

Check discussion in https://community.plone.org/t/do-we-still-need-portal-modifiers-from-products-cmfeditions-for-dexterity-file-type-with-blobs/2518

@alecpm @iham @gforcada @rafaelbco @mauritsvanrees @hannosch

[alecpm]

This modifier was intended only for handing of OFS File/Image objects (i.e. non-blob files using Pdata chains) stored as attributes, i.e. old-style non-blob AT File and AT Image fields. It appears that the plone.app.contenttypes file and image object support the APIs, the modifier expects, so it treats those as if they are old-style non-blob Files and aborts the version to avoid recursion errors and segfaults during pickling. It should be fine to disable the modifier on sites which don't make use of old-style AT Image/File fields. Better would be to update the modifier to explicitly check the type of the file object being inspected (e.g.isinstance(f, OFS.Image.File))