-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make application geometries with non-matching grids #1312
Comments
Just to give my unsolicited two cents since I'm currently working with non-matching grids: Another option, instead of focusing on individual geometries (such as |
I agree that your suggestion is more useful in a general setting @jhabriel. If we end up applying non-matching grids more regularly, we will likely do something in the direction you sketch, or better, rely on functionality that you implement. The goal of this project is however limited to enabling testing on non-matching grids at all, and then (later) to do some diagnostics of which models are ready for non-matching grids. I expect this to be an efficient generator of GH issues. |
@IngridKJ @zhangyh0713 I took a short peak at the branch you are working on, and want to offload my thoughts here: it seems you are well under way; just be aware that the domain you are working with ( When the mixin geometry is in place, I think we will use the new grid in one test, perhaps tests/models/test_fluid_mass_balance.py::test_unit_conversion. If this works, I think we are good, and can make a full PR. If it does not work, we need to look into why, but it could very well be that this is also outside the scope of this issue. |
Thank you for the feedback, @keileg! We are aware of the usage of |
Partly yes. Also, if you try to replace a fracture grid, but |
Thanks for the feedback @keileg ! We will fix this problem:) |
Currently the available model geometries used for testing (e.g., applications/model_geometries.py) exclusively apply matching geometries. We should make a few cases available.
Suggested approach for the initial steps:
self.mdg
.It is an open question how many of the tests, and PorePy functionality in general, will be able to deal with non-matching grids, but that is a secondary concern.
The text was updated successfully, but these errors were encountered: