Batching BreakRoleInheritance and RoleDefinition Updates

[kentlhastings]

Hello all,

I'm trying to execute the following code using nightly release 1.0.20, and although I execute the breakRoleInheritance batch synchronously, I still get an exception when I try to execute the batch that adds the roles/definitions. The exception states that the operation cannot be completed on an object that inherits permissions.

As always, I appreciate your assistance!

private async Task ChangeAllPermissions(List folders, List files, RoleDefinition permissions, PnPContext batchContext, string projectNumber)

    {
        try
        {
            foreach (var file in files)
                await file.ListItemAllFields.BreakRoleInheritanceBatchAsync(false, true);

            foreach (var folder in folders)
                await folder.ListItemAllFields.BreakRoleInheritanceBatchAsync(false, true);

            batchContext.Execute();
        }
        catch (Exception)
        {
            throw new Exception($"Failed to break role inheritance for project resources for {projectNumber}");
        }

        try
        {
            foreach (var file in files)
            {
                Console.WriteLine($"Applying role/permission to {file.ServerRelativeUrl}");
                foreach (var permission in permissions.RoleDefinitions)
                {
                    foreach (var definition in permission.Value)
                        await file.ListItemAllFields.AddRoleDefinitionBatchAsync(permission.Key, definition);
                }
            }

            foreach (var folder in folders)
            {
                Console.WriteLine($"Applying role/permission to {folder.ServerRelativeUrl}");
                foreach (var permission in permissions.RoleDefinitions)
                {
                    foreach (var definition in permission.Value)
                        await folder.ListItemAllFields.AddRoleDefinitionBatchAsync(permission.Key, definition);
                }
            }

            await batchContext.ExecuteAsync();
        }

[kentlhastings]

Reversing the orders of the files' and folders' BreakRoleInheritance batches fixed the issue. Thank you!