-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientSidePages ex- and re-import does not work when M365 Rodmap feature 386904 is active in the tenant #1043
Comments
Additionally, when using page-templates created from a pnp-template, "strange" things happen to the title:
<pnp:Provisioning xmlns:pnp="http://schemas.dev.office.com/PnP/2022/09/ProvisioningSchema">
<pnp:Preferences Generator="PnP.Framework, Version=1.15.95.0, Culture=neutral, PublicKeyToken=0d501f89f11b748c" />
<pnp:Templates ID="CONTAINER-TEMPLATE-79AA4DF1BA094052A6169EA560E53F36">
<pnp:ProvisioningTemplate ID="TEMPLATE-79AA4DF1BA094052A6169EA560E53F36" Version="0" Scope="Undefined">
<pnp:ClientSidePages>
<pnp:ClientSidePage PromoteAsNewsArticle="false" PromoteAsTemplate="true" Overwrite="true" Title="New Test" ThumbnailUrl="" PageName="Templates/New-Test.aspx">
<pnp:Header Type="Default" LayoutType="FullWidthImage" ShowTopicHeader="false" ShowPublishDate="false" ShowBackgroundGradient="false" TopicHeader="" AlternativeText="" Authors="" AuthorByLineId="17" />
<pnp:Sections>
<pnp:Section Order="1" Type="OneColumnVerticalSection">
<pnp:Controls>
<pnp:CanvasControl WebPartType="Text" ControlId="1212fc8d-dd6b-408a-8d5d-9f1cc787efbb" Order="1" Column="1">
<pnp:CanvasControlProperties>
<pnp:CanvasControlProperty Key="Text" Value="Some text here" />
</pnp:CanvasControlProperties>
</pnp:CanvasControl>
<pnp:CanvasControl WebPartType="Text" ControlId="1212fc8d-dd6b-408a-8d5d-9f1cc787efbc" Order="1" Column="2">
<pnp:CanvasControlProperties>
<pnp:CanvasControlProperty Key="Text" Value="Some text in the left colum" />
</pnp:CanvasControlProperties>
</pnp:CanvasControl>
</pnp:Controls>
</pnp:Section>
<pnp:Section Order="2" Type="OneColumn">
<pnp:Controls>
<pnp:CanvasControl WebPartType="Text" ControlId="1212fc8d-dd6b-408a-8d5d-9f1cc787efbd" Order="1" Column="1">
<pnp:CanvasControlProperties>
<pnp:CanvasControlProperty Key="Text" Value="more text here" />
</pnp:CanvasControlProperties>
</pnp:CanvasControl>
</pnp:Controls>
</pnp:Section>
</pnp:Sections>
</pnp:ClientSidePage>
</pnp:ClientSidePages>
</pnp:ProvisioningTemplate>
</pnp:Templates>
</pnp:Provisioning> (Kindly ignore, that the text saying "Some text in the left colum" actually is in the right column and contains a typo. 🙄) now, the fun begins... |
Hi, i have opened a similar issue here: |
I also noticed the same thing in #1038. |
We have the same thing on tenants where the new section possibilities and banner webparts are available - but not too many have that at this point of time. Workaround: Remove the full width section in page templates, use a normal section with Text webpart. After provisioning make sure people add the full width section with banner. Not nice. Any updates? @nils-a @cwparsons? |
None. We're currently alternating between not using PnP provisioning at all, and provisioning using PnP with additional manual "cleanup". |
The specific Stacktrace for that Error It would need to be fixed here: both packages have to be updated after as pnp.framework relates to pnp.core for pages Message ID: MC791596 What actually changed is, that we have now a to section with a specific webPart for the Page-Title |
@czullu : thanks for your PR in PnPCore! I'll test and merge this |
@czullu : thanks for the changes, they worked fine and I've merged them! These changes will be part of the next nightly, which I'll trigger manually so you have the updates within a few minutes @nils-a , @cwparsons , @marcoschmucker , @Raven081189 : FYI |
@jansenbe : this problem is still active for different page layouts (vertical column, TwoColumnLeft) - can you re-open the issue? @czullu : since you already resolved the issue related to OneColumn layouts and the new Header Section, do you have time to fix the other page layouts, too? That would be amazing. |
Working on Fix - needs to done in pnp.core and pnp.framework. Gooing by assumption that we have new Header if we have any section of type "OneColumnFullWith" with the PageTitle-WebPart in it (not only the first section). |
I'm a bit confused, currently. Should this be fixed? |
For anyone landing in this post in version 2.99.33-nightly seems fixed and is working correctly (need to use powershell 7 to install the version) |
@Frau87 : this is not correct - the issue is still reproducible for several page layouts (e.g.: OneColumn + VerticalSection) - just did the test with 2.99.34-nightly |
Feature 386904
Steps to reproduce
connect-pnponline -Interactive <yoursite>
export-PnPPage "<yourpage>.aspx" -out test.xml
PageTitle
webpart, in aOneColumnFullWidth
section.invoke-pnpsitetemplate -path test.xml
The text was updated successfully, but these errors were encountered: