Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill missing properties in React Document Reporting Field Customizer sample.json #1396

Closed
Adam-it opened this issue Aug 10, 2024 · 0 comments · Fixed by #1397
Closed

Fill missing properties in React Document Reporting Field Customizer sample.json #1396

Adam-it opened this issue Aug 10, 2024 · 0 comments · Fixed by #1397
Assignees
Labels
status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability

Comments

@Adam-it
Copy link
Member

Adam-it commented Aug 10, 2024

Sample

/samples/react-field-reporting

Author(s)

Ejaz Hussain

Suggestion

In the sample.json we missed some TODO placeholders. It would be best to replace them with some related content as this will not look nice in the Microsoft sample gallery nor in the SPFx Toolkits embedded sample gallery 😉
Currently it looks like this

    "title": "TODO: TITLE-GOES-HERE", 
     "shortDescription": "DESCRIPTION-GOES-HERE", 
     "url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/react-field-reporting", 
     "longDescription": [ 
       "TODO: LONG-DESCRIPTION-GOES-HERE"

Mentioned file: https://github.com/pnp/sp-dev-fx-extensions/blob/main/samples%2Freact-field-reporting%2Fassets%2Fsample.json

Are you willing to help?

Yes

@Adam-it Adam-it self-assigned this Aug 10, 2024
@Adam-it Adam-it added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:enhancement New feature or enhancement of existing capability
Projects
None yet
1 participant